lkml.org 
[lkml]   [2002]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] Important per-cpu fix.
Date
In message <20020909.011539.122194350.davem@redhat.com> you write:
> I want *you* to feel the pain, not spread it around by leaving turds
> throughout the code long after the bug is forgotten:
>
> Aha, but it is you putting the turd comments all over. I'm
> suggesting to put the turd in one place, the header file.

.... and every user of it...

> And how difficult is it to discern which initializers were
> needed? Hmmm let me see, if it was all zero --> removing it
> is harmless.

Let's not get onto initializer wars: I initialize all my variables
exactly once, so there's serious semantic difference between "static
int x;" and "static int x = 0;" in my code.

> Both of us are advocating adding shit to the tree, the only argument
> is which stinks less from a maintainence perspective.

Hey, I'm not stopping you sending a patch to Linus, but given how we
deprecated compilers on x86, I don't think he'll have sympathy for
you in 2.6.

Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:28    [W:0.106 / U:0.208 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site