lkml.org 
[lkml]   [2002]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: Linux 2.4.20-pre6
From
Date
On Wed, 2002-09-11 at 00:14, Jean Tourrilhes wrote:
> > This adds the use of TIOCM_MODEM_BITS to irtty.c but not the corresponding
> > addition of it to asm-i386/termios.h:
>
> I would personally would have veto'ed that change, because it
> will work only on i386 (and PA-Risc), whereas the IrDA stack is
> routinely used on ARM and PPC and also work on Alpha.

The change got it by accident

> I would personally perfer the header to define a "default"
> value, and only the broken architecture would need to override it
> (#undef + #define).

absolutely

> So, as people like quick'n'dirty hacks, just make sure that
> TIOCM_MODEM_BITS is also defined in ARM, SH, PPC and Alpha (at least),
> just to make sure I'm the only one complaining.

They are in my tree.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:28    [W:0.044 / U:0.836 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site