Messages in this thread |  | | Date | Sun, 1 Sep 2002 11:03:44 -0700 (PDT) | From | Linus Torvalds <> | Subject | Re: 2.5.33-bk testing |
| |
On Sun, 1 Sep 2002, Mikael Pettersson wrote: > > The patch below is an update of the floppy workarounds patch > I've been maintaining since the problems began in 2.5.13. > With this patch I'm able to reliably read and write to the > raw /dev/fd0 device. I'm not suggesting that my hack to > bdev->bd_block_size is the correct fix, but maybe someone who > understands the block I/O system can see what's going on and > do a proper fix.
It looks like what your fix does is to force a 512-byte blocksize on the floppy.
Which implies to me that the floppy driver is broken for other blocksizes.
Does your patch still leave the floppy driver broken for something like a mounted minix or ext2 filesystem? Those have 1kB blocksizes, and will set it to that. If the non-512B blocksize in the floppy driver is broken, then such mounted filesystems should not work reliably either.
Linus
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |