Messages in this thread | | | Date | Fri, 9 Aug 2002 21:16:52 +0400 | From | Ivan Kokshaysky <> | Subject | Re: PCI<->PCI bridges, transparent resource fix |
| |
On Fri, Aug 09, 2002 at 10:06:30AM +0200, Benjamin Herrenschmidt wrote: > BTW, in the case of really closed resources, you just removed the "else" > case. I don't have the kernel sources at hand at the moment (still > on vacation ;) So I can't check how pci_dev is initialized on alloc,
It's zeroed.
> but shouldn't we make sure the resoure pointer of the child is either > NULL or points to some properly zeroed out resource structure ?
I'm not sure whether it could happen in current 2.4/2.5 code, but if pci_read_bridge_bases() is called from hotplug code, and bridge's window changes from "enabled" to "disabled" (card removed), then yes, we must set resource.flags = 0.
Ivan. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |