Messages in this thread | | | Date | Thu, 08 Aug 2002 11:20:50 -0500 | From | Dave McCracken <> | Subject | Re: [PATCH 2.5.30+] Second attempt at a shared credentials patch |
| |
--On Thursday, August 08, 2002 05:32:05 PM +0200 Trond Myklebust <trond.myklebust@fys.uio.no> wrote:
> What the hell is that change to fs/nfs/dir.c below all about? Try > mounting an NFSv2 partition with that applied...
Oops. Looks like I managed to make a mistake in merging. Here's a fixed version:
http://www.ibm.com/linux/ltc/patches/misc/cred-2.5.30-4.diff.gz
> Instead of doing this as one big unreadable monolithic patch and > risking getting things wrong like in the above case, it would be nice > if you could go via a set of wrapper functions: > ># define get_current_uid() (current->uid) ># define set_current_uid(a) current->uid = a
I don't see this as a win. I *could* do a big monolithic patch to change all references to current->*id to macros, then change the macros in a separate patch. But then we'd be stuck with macros for all those references forever, and they're not likely to change again any time soon. I don't think we'd really want to have macros for all our structure references on the off chance that someone might change it in the future.
Dave McCracken
====================================================================== Dave McCracken IBM Linux Base Kernel Team 1-512-838-3059 dmccr@us.ibm.com T/L 678-3059
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |