lkml.org 
[lkml]   [2002]   [Aug]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] trivial patch for 2.4.20-pre1 8139too.c driver (fwd)
Date
My i ask what the sense is to not remove the dead code if
all we are trying to do is stablize the 2.4x kernel series
and not add extra code or change around the drivers for
perticular hardware. The code is not used anymore so why
keep it in the 2.4x series. The code can stay in the 2.5x
series no problem because there we can change drivers
rewrite hardware protocalls and tthings like that.


Marcelo Tosatti wrote:
>
>---------- Forwarded message ----------
>Date: Tue, 6 Aug 2002 00:15:21 +0000
>From: Nathaniel Russell <reddog83@chartermi.net>
>To: marcelo@conectiva.com.br
>Cc: alan@lxorguk.ukuu.org.uk
>Subject: [PATCH] trivial patch for 2.4.20-pre1 8139too.c
driver
>
>This patch removes unneeded code for the Realtek driver
this patch does not
>harm the performance of the driver at all it just removes
dead code
>
>
>------------------------------------------------------------------------
>
>diff -urN linux-2.4/drivers/net/8139too.c.tmp
linux/drivers/net/8139too.c
>--- linux-2.4/drivers/net/8139too.c.tmp Mon Aug 5
18:06:03 2002
>+++ linux/drivers/net/8139.c Tue Aug 6 00:09:20 2002
>@@ -211,7 +211,6 @@
> RTL8139 = 0,
> RTL8139_CB,
> SMC1211TX,
>- /*MPX5030,*/
> DELTA8139,
> ADDTRON8139,
> DFE538TX,
[...]


Please -do not- apply this patch. This "dead code" exists
for comment purposes, and also is a placeholder for
future, better support for this chip.

Jeff





-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:27    [W:0.037 / U:0.428 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site