[lkml]   [2002]   [Aug]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: usb devicefs flaw
    > Fix is already in Linus's tree, thanks to David Brownell

    For myself I had made the fix with * instead of /.
    But yes, 0 is unambiguous.

    Another problem that I see under not yet determined circumstances
    is "Too many links" when I do "cat product" or "cat manufacturer"
    for some USB device in the devicefs tree.
    This -EMLINK smells like some random negative number.
    Now usb_string() in usb/core/message.c can return an error,
    but routines like show_product() and show_manufacturer()
    in usb/core/usb.c blindly do
    len = usb_string(...);
    buf[len] = '\n';
    buf[len+1] = 0x00;
    return len+1;
    so that in case of an error some random memory is corrupted.
    In other words: everywhere the return value of usb_string()
    must be checked.


    [Concerning the -EMLINK, I bet that usb_string() returned -EPIPE
    which is -32, so that here -31, that is, -EMLINK, is returned.]
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2005-03-22 13:27    [W:0.039 / U:0.856 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site