Messages in this thread |  | | Date | Fri, 30 Aug 2002 16:42:39 -0700 (PDT) | From | Linus Torvalds <> | Subject | Re: [PATCH] compile fix for fs/aio.c on non-highmem systems |
| |
On Fri, 30 Aug 2002, David S. Miller wrote: > > Patrik Mochel noticed that fs/aio.c doesn't compile on a non-highmem config. > The patch below (and in the bk tree on master.kernel.org:/home/bcrl/aio-2.5) > fixes that by making the helper functions #defines, and should also be a > bit faster. > > Platforms should fix this by making a dummy asm/kmap_types.h > > Linus added the explicit include of asm/kmap_types.h and therefore > I believe this is how he wants this fixed too.
I don't really much care how it gets fixed, I could equally well imagine having a dummy struct when CONFIG_HIGHMEM isn't set. Whatever makes the dang thing work. There's certainly a good argument that non-broken architectures shouldn't need to bother with kmap() at all..
Linus
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |