lkml.org 
[lkml]   [2002]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
SubjectRe: [GENERIC HDLC LAYER] Messages of a hdlc device
Date
> I'm using the generic hdlc layer with PPP protocol
against a Lucent MAX6000.
> Everything works OK but there a kernel message bothering
me:
> protocol 0008 is buggy, dev hdlc0
>
> I get this message nearly once per minute.
>
> Do anyone know what is this message about ?

I've seen that problem since 2.2.x kernels.
I think there is an error while building cisco/ppp
keepalive packet (hdlc.c & syncppp.c).
Lines skb->nh.raw = skb->data;
will solve it.
Following patch is for 2.2.x kernel.
If you want to patch 2.4.x, simply add
skb->nh.raw = skb->data;
at cisco_keepalive_send (hdlc.c)
at sppp_cisco_send (syncppp.c)
and at sppp_cp_send (syncppp.c)

Here is a patch(for hdlc.c & syncppp.c from 2.2.x):
==========================
diff -urN kernel-source-2.2.17.orig/drivers/net/hdlc.c
kernel-source-2.2.17.hdlc_patch/drivers/net/hdlc.c
--- kernel-source-2.2.17.orig/drivers/net/hdlc.c Sat Jun 24
15:25:37 2000
+++ kernel-source-2.2.17.hdlc_patch/drivers/net/hdlc.c Fri
Mar 22 19:51:41 2002
@@ -19,6 +19,13 @@
*
* Use sethdlc utility to set line parameters, protocol
and PVCs
*/
+ /*
+ Patched by Pavel Selivanov. 08 Aug. 2001
+ If we are using dev_queue_xmit, and we have a
listeners,
+ we should set skb->nh.raw. If no, we'll get a lot of
warnings in
+ /var/log/debug
+ Look at core/net/dev.c dev_queue_xmit_nit
+*/

#include <linux/config.h>
#include <linux/module.h>
@@ -99,6 +106,7 @@
skb_put(skb, sizeof(cisco_packet));
skb->priority=TC_PRIO_CONTROL;
skb->dev = hdlc_to_dev(hdlc);
+ skb->nh.raw = skb->data;

dev_queue_xmit(skb);
}
@@ -369,7 +377,8 @@
skb_put(skb, i);
skb->priority=TC_PRIO_CONTROL;
skb->dev = hdlc_to_dev(hdlc);
-
+ skb->nh.raw = skb->data;
+
dev_queue_xmit(skb);
}

@@ -805,6 +814,7 @@
{
pvc_device *pvc=dev_to_pvc(dev);

+ skb->nh.raw = skb->data;
if (pvc->state & PVC_STATE_ACTIVE) {
skb->dev = hdlc_to_dev(pvc->master);
pvc->stats.tx_bytes+=skb->len;
diff -urN kernel-source-2.2.17.orig/drivers/net/syncppp.c
kernel-source-2.2.17.hdlc_patch/drivers/net/syncppp.c
--- kernel-source-2.2.17.orig/drivers/net/syncppp.c Thu Jun
8 04:26:43 2000
+++
kernel-source-2.2.17.hdlc_patch/drivers/net/syncppp.c Fri
Mar 22 19:51:41 2002
@@ -16,7 +16,14 @@
*
* Port for Linux-2.1 by Jan "Yenya" Kasprzak
<kas@fi.muni.cz>
*/
-
+ /*
+ Patched by Pavel Selivanov. 08 Aug. 2001
+ If we are using dev_queue_xmit, and we have a listeners,
+ we should set skb->nh.raw. If no, we'll get a lot of
warnings in
+ /var/log/debug
+ Look at core/net/dev.c dev_queue_xmit_nit
+*/
+
/*
* Synchronous PPP/Cisco link level subroutines.
* Keepalive protocol implemented in both Cisco and PPP
modes.
@@ -779,6 +786,8 @@
/* Control is high priority so it doesnt get queued
behind data */
skb->priority=TC_PRIO_CONTROL;
skb->dev = dev;
+ skb->nh.raw = skb->data;
+
dev_queue_xmit(skb);
}

@@ -821,6 +830,8 @@
sp->obytes += skb->len;
skb->priority=TC_PRIO_CONTROL;
skb->dev = dev;
+ skb->nh.raw = skb->data;
+
dev_queue_xmit(skb);
}
======================

Regards
Pavel
mail: pavel[AT]parabel.inc.ru
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
\
 
 \ /
  Last update: 2005-03-22 13:28    [W:0.026 / U:10.240 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site