lkml.org 
[lkml]   [2002]   [Aug]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: Compilation errors in 2.4.20.rc5
From
On Thu, Aug 29, 2002 at 10:09:45PM -0400, B. Joshua Rosen wrote:
> -o wavelan_cs.o wavelan_cs.c
> In file included from wavelan_cs.c:66:
> /home/tmp/linux/include/linux/ethtool.h:18: parse error before `u32'
> /home/tmp/linux/include/linux/ethtool.h:18: warning: no semicolon at end
> of struct or union
> /home/tmp/linux/include/linux/ethtool.h:19: warning: type defaults to
> `int' in declaration of `supported'

Ok, I'll forward...

hch@lst.de (or whoever did that) :
1) I don't really think that a wireless driver will get much
benefit from ethtool (try setting full duplex ;-)
2) Headers are added in the file wavelan_cs.h, to keep
wavelan.c clean and tidy. And this would have avoided the bug.
3) It take only 2 second to try to compile before submitting
your changes. Even the best of us do it.
4) A MAINTAINER is not someone that clean up after the mess of
other people. I usually answer my e-mail, and I could have both answer
your question and reviewed the patch.

So, please clean up your mess...

Jean
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:28    [W:0.019 / U:4.628 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site