lkml.org 
[lkml]   [2002]   [Aug]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: /pub/linux/kernel/people/hedrick/ide-2.5.32
Andre Hedrick wrote:
>
> ...
> There is one more thing to fix.
>
> ./fs/mpage.c
>
> /*
> * The largest-sized BIO which this code will assemble, in bytes. Set this
> * to PAGE_CACHE_SIZE if your drivers are broken.
> */
> #define MPAGE_BIO_MAX_SIZE 32768 //BIO_MAX_SIZE
>
> This is confirmed with Al Viro and was required to make things sane!

You'll need to do the same thing to fs/direct-io.c:DIO_BIO_MAX_SIZE
in that case.

I'd suggest that you just go in and change BIO_MAX_SECTORS
to 64. Or 32 if you happen to be using a qlogic controller :(

So everything's broken in there - a hardwired constant doesn't
cut it. Jens is cooking up an `add_page_to_bio()' API which
will do the right thing based upon q->max_sectors. But that
is not yet available.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:28    [W:0.034 / U:10.416 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site