lkml.org 
[lkml]   [2002]   [Aug]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[Patch 3/8] 2.4.20-pre4/ext3: Fix the "dump corrupts filesystems" buffer-cache bug.
Since block-dev-in-page-cache was added in 2.4.10, and the aliasing between
buffered devices and getblk() was restored in 2.4.11, getblk() and friends
can be performing IO on a page cache page without the page cache lock
being held. The page cache IO assumes that the page cache lock is enough
to synchronise things safely, but this breaks if we get aliased IO.

In particular, block_read_full_page() assumes that it is safe to begin IO
on any non-uptodate bh, regardless of the locked status of the bh. To be
safe, we need to test the uptodate state *after* taking the bh lock.

Already in 2.5.

--- linux-ext3-2.4merge/fs/buffer.c.=K0004=.orig Tue Aug 27 23:14:15 2002
+++ linux-ext3-2.4merge/fs/buffer.c Tue Aug 27 23:19:57 2002
@@ -1748,9 +1748,14 @@
}

/* Stage 3: start the IO */
- for (i = 0; i < nr; i++)
- submit_bh(READ, arr[i]);
-
+ for (i = 0; i < nr; i++) {
+ struct buffer_head * bh = arr[i];
+ if (buffer_uptodate(bh))
+ end_buffer_io_async(bh, 1);
+ else
+ submit_bh(READ, bh);
+ }
+
return 0;
}

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
\
 
 \ /
  Last update: 2005-03-22 13:28    [W:0.025 / U:12.472 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site