lkml.org 
[lkml]   [2002]   [Aug]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] M386 flush_one_tlb invlpg
    CONFIG_M386 kernel running on PPro+ processor with X86_FEATURE_PGE may
    set _PAGE_GLOBAL bit: then __flush_tlb_one must use invlpg instruction.

    The need for this was shown by a recent HyperThreading discussion.
    Marc Dietrich reported (LKML 22 Aug) that CONFIG_M386 CONFIG_SMP kernel
    on P4 Xeon did not support HT: his dmesg showed acpi_tables_init failed
    from bad table data due to unflushed TLB: he confirms patch fixes it.

    No tears would be shed if CONFIG_M386 could not support HT, but bad TLB
    is trouble. Same CONFIG_M386 bug affects CONFIG_HIGHMEM's kmap_atomic,
    and potentially dmi_scan (now using set_fixmap via bt_ioremap). Though
    it's true that none of these uses really needs _PAGE_GLOBAL bit itself.

    I just sent the 2.4.20-pre4 asm-i386/pgtable.h patch to Marcelo:
    here's patch against 2.5.31 or current BK: please apply.

    Hugh

    --- 2.5.31/include/asm-i386/tlbflush.h Tue Jun 4 14:27:14 2002
    +++ linux/include/asm-i386/tlbflush.h Tue Aug 27 15:30:53 2002
    @@ -45,11 +45,19 @@
    __flush_tlb(); \
    } while (0)

    -#ifndef CONFIG_X86_INVLPG
    -#define __flush_tlb_one(addr) __flush_tlb()
    +#define __flush_tlb_single(addr) \
    + __asm__ __volatile__("invlpg %0": :"m" (*(char *) addr))
    +
    +#ifdef CONFIG_X86_INVLPG
    +# define __flush_tlb_one(addr) __flush_tlb_single(addr)
    #else
    -#define __flush_tlb_one(addr) \
    -__asm__ __volatile__("invlpg %0": :"m" (*(char *) addr))
    +# define __flush_tlb_one(addr) \
    + do { \
    + if (cpu_has_pge) \
    + __flush_tlb_single(addr); \
    + else \
    + __flush_tlb(); \
    + } while (0)
    #endif

    /*
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:28    [W:0.023 / U:1.800 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site