lkml.org 
[lkml]   [2002]   [Aug]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [patch] clone-detached-2.5.31-B0
From
Date
On Mon, 2002-08-26 at 08:35, Pavel Machek wrote:

> > --- kernel/signal.c.orig Thu Aug 15 17:12:02 2002
> > +++ kernel/signal.c Thu Aug 15 17:12:34 2002
> > @@ -774,7 +774,7 @@
> > int why, status;
> >
> > /* is the thread detached? */
> > - if (sig == -1 || tsk->exit_signal == -1)
> > + if (sig == -1)
> > BUG();
> >
> > info.si_signo = sig;
>
> Why not BUG_ON()?

Ingo has said previously that he does not like the syntax of BUG_ON.

I disagree, but it is his code - what we _should_ do here is mark the
branch unlikey() if nothing else.

Robert Love

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:28    [W:0.108 / U:0.576 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site