Messages in this thread |  | | Date | Mon, 26 Aug 2002 18:33:16 +0200 | From | Vojtech Pavlik <> | Subject | Re: [PATCH] reduce CONFIG_INPUT as forward symbol (with diff) |
| |
On Mon, Aug 26, 2002 at 09:28:08AM -0700, Randy.Dunlap wrote: > [repost with patch this time] > > Hi, > > I've been using gcml2 from Greg Banks to look at CONFIG_ > variable dependencies in config.in files. > > By moving drivers/input/config.in before drivers/char/Config.in > and drivers/usb/Config.in for arch/alpha and arch/mips(64), > several (7) instances of this message: > forward declared symbol "CONFIG_INPUT" used in dependency list > and (6) instances of this one: > forward declared symbol "CONFIG_SOUND_GAMEPORT" used in > dependency list > can be removed. (Yes, the latter one is for OSS drivers, > so it's not so important.) > > It also adds one forward dependency for a USB joystick > in the input subsystem [still only for alpha and mips(64)]. > Most other arches are already like this. > > This patch is to 2.5.31-bk7 (jgarzik's latest snapshot). > Please apply. > > On Mon, 26 Aug 2002, Vojtech Pavlik wrote: > | > | I'd like to take a look at the patch - both the symbols are from the > | input drivers. Where can I find it? And what was the exact problem? > > Yes, I forgot the patch...too late last night. > It's now below. > > This patch just makes alpha and mips(64) use the same ordering > for "source drivers/input/Config.in" that most other arches use, > so that there are fewer forward references to CONFIG_INPUT. > > Please apply.
I see. Yes, this is correct.
> --- ./arch/alpha/config.in.inputt Sun Aug 25 21:14:09 2002 > +++ ./arch/alpha/config.in Sun Aug 25 21:37:33 2002 > @@ -335,6 +335,7 @@ > fi > endmenu > > +source drivers/input/Config.in > source drivers/char/Config.in > source drivers/char/Config-tape.in > > @@ -371,7 +372,6 @@ > endmenu > > source drivers/usb/Config.in > -source drivers/input/Config.in > > source net/bluetooth/Config.in > > --- ./arch/mips64/config.in.inputt Sun Aug 25 21:14:09 2002 > +++ ./arch/mips64/config.in Sun Aug 25 22:08:45 2002 > @@ -186,6 +186,8 @@ > fi > endmenu > > +source drivers/input/Config.in > + > source drivers/char/Config.in > > source drivers/char/Config-tape.in > @@ -229,7 +231,6 @@ > fi > > source drivers/usb/Config.in > -source drivers/input/Config.in > > mainmenu_option next_comment > comment 'Kernel hacking' > --- ./arch/mips/config.in.inputt Sun Aug 25 21:14:09 2002 > +++ ./arch/mips/config.in Sun Aug 25 22:04:30 2002 > @@ -395,6 +395,8 @@ > fi > endmenu > > +source drivers/input/Config.in > + > source drivers/char/Config.in > > source drivers/char/Config-tape.in > @@ -482,7 +484,6 @@ > fi > > source drivers/usb/Config.in > -source drivers/input/Config.in > > mainmenu_option next_comment > comment 'Kernel hacking'
-- Vojtech Pavlik SuSE Labs - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |