lkml.org 
[lkml]   [2002]   [Aug]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] (re)implement setkeycode/getkeycode/kd_mksound/kbd_setrate via the input core

This bit looks wrong to me:

+ for (handle = kbd_handler.handle; handle; handle = handle->hnext)
+ if (handle->dev->keycodesize) break;
+
+ if (!handle->dev->keycodesize)
+ return -ENODEV;

if we reach termination for the loop without finding a keycodesize, handle
will be NULL, so you'd get an oops. Just do:

+ if (!handle)
+ return -ENODEV

(sorry about the formatting, i'm reading l-k via uwsg's web archive).

--
Revolutions do not require corporate support.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:28    [W:0.024 / U:0.792 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site