lkml.org 
[lkml]   [2002]   [Aug]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Fwd: [PATCH] reduce size of bridge regions for yenta.c]
H. J. Lu wrote:
> I don't like it at all. That change is not right. Usually the PCI
> bridge before the CardBus bridge is transparent.

And what if the PCI bridge is not transparent? What if it's a server
with a riser card, and a cardbus bridge to attach a WLAN card? That
setup is quite common.

yenta.c doesn't contain error handling, and that should be fixed.

>
> H.J.
> On Sat, Aug 24, 2002 at 11:09:36PM -0700, Andrew Morton wrote:
>
>>You guys may need this...

IMHO both patches are needed:

The current code that detects transparent bridges [bridges that
implement subtractive decoding would be a better name] is bad, Ivan's
patch fixes that.

My patch adds error handling to yenta.c. It's not strictly needed,
because most PCI bridges in laptops forward all requests, and thus there
is enough iomem space for the 8 MB allocation, but the lack of error
handling [and lack of printks] just asks for trouble.

--
Manfred

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:28    [W:0.058 / U:5.344 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site