lkml.org 
[lkml]   [2002]   [Aug]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: OOPS: USB and/or devicefs

On 25 Aug 2002, Nicholas Miell wrote:

> I'm not sure what caused this exactly -- I unplugged a USB hub and then
> did a ls in the hub's directory in the devicefs. The ls died (in D
> state), and I found this in my logs.

> 00000000 <_EIP>:
> Code; c015b40f <driverfs_unlink+f/40> <=====
> 0: ff 4f 5c decl 0x5c(%edi) <=====
> Code; c015b412 <driverfs_unlink+12/40>
> 3: 0f 88 39 08 00 00 js 842 <_EIP+0x842> c015bc51 <.text.lock.inode+0/bf>
> Code; c015b418 <driverfs_unlink+18/40>
> 9: 8b 46 08 mov 0x8(%esi),%eax
> Code; c015b41b <driverfs_unlink+1b/40>
> c: 66 ff 48 24 decw 0x24(%eax)
> Code; c015b41f <driverfs_unlink+1f/40>
> 10: 56 push %esi
> Code; c015b420 <driverfs_unlink+20/40>
> 11: e8 fb ab 00 00 call ac11 <_EIP+0xac11> c0166020 <sys_shmctl+170/880>


A dentry has been created with no inode associated with it, and
driverfs_unlink() attempts to access it without checking it.

Could you please try the attached patch and let me know if it helps?

Thanks,

-pat

===== fs/driverfs/inode.c 1.48 vs edited =====
--- 1.48/fs/driverfs/inode.c Mon Aug 5 11:13:07 2002
+++ edited/fs/driverfs/inode.c Sun Aug 25 15:13:51 2002
@@ -211,11 +211,13 @@
static int driverfs_unlink(struct inode *dir, struct dentry *dentry)
{
struct inode *inode = dentry->d_inode;
- down(&inode->i_sem);
- dentry->d_inode->i_nlink--;
- dput(dentry);
- up(&inode->i_sem);
- d_delete(dentry);
+ if (inode) {
+ down(&inode->i_sem);
+ dentry->d_inode->i_nlink--;
+ dput(dentry);
+ up(&inode->i_sem);
+ d_delete(dentry);
+ }
return 0;
}

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:28    [W:0.062 / U:6.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site