Messages in this thread Patch in this message |  | | Date | Sat, 24 Aug 2002 05:44:16 -0700 | From | silvio@qualys ... | Subject | [PATCH] linux-2.4.19/drivers/ieee1394/video1394.c |
| |
avoid possible integer overflow
(also change the <= to just != since its using unsigned types anyway making the sign test invalid here *shrug*)
-- Silvio --- linux-2.4.19/drivers/ieee1394/video1394.c Sat Aug 24 05:37:15 2002 +++ linux-2.4.19-dev/drivers/ieee1394/video1394.c Sat Aug 24 05:40:22 2002 @@ -871,13 +871,13 @@ } ohci->ISO_channel_usage |= mask; - if (v.buf_size<=0) { + if (v.buf_size == 0 || v.buf_size > VIDEO1394_MAX_SIZE) { PRINT(KERN_ERR, ohci->id, "Invalid %d length buffer requested",v.buf_size); return -EFAULT; } - if (v.nb_buffers<=0) { + if (v.nb_buffers == 0 || v.nb_buffers > VIDEO1394_MAX_SIZE) { PRINT(KERN_ERR, ohci->id, "Invalid %d buffers requested",v.nb_buffers); return -EFAULT; |  |