Messages in this thread |  | | Date | Fri, 23 Aug 2002 20:11:33 +0100 | From | Christoph Hellwig <> | Subject | Re: [patch, 2.5] vmalloc.c error path fixes |
| |
On Tue, Aug 20, 2002 at 11:35:33AM -0700, Andrew Morton wrote: > > of the diff fix a spinlock being held if an error occurs in > > map_vm_area, and the last part fixes the error path of __vmalloc. > > Certainly agree on the first chunk. Listen to the old guy: "Thou > shalt not have more than one return statement per function". > > Second chunk looks good too, but perhaps there's another way of doing > it. The 2.5.31 code just tossed it all at vfree. Perhaps hch can > comment?
The code looks fine - I missed that error checking. A little nitpick: either remove the comment inn the last chunk as it's obvious what we are doing or at least make it fit an ansi terminal. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |