Messages in this thread |  | | Date | Thu, 22 Aug 2002 11:57:29 -0400 | From | Benjamin LaHaise <> | Subject | Re: [PATCH] printk simultaneous oops disentangling |
| |
On Thu, Aug 22, 2002 at 11:51:14AM -0400, Benjamin LaHaise wrote: > On Thu, Aug 22, 2002 at 01:09:18PM +0100, David Howells wrote: > > Hi Linus, > > > > Here's a patch to stop multiple simultaneous oopses on an SMP system from > > interleaving with and overwriting bits of each other. It only permits lock > > breaking if the printk lock is held by the same CPU. > > This is still wrong. It should attempt to acquire the locks with a timeout > before trampling on them, as there may be a printk or other console output > in progress on the other cpu.
/me must be having a bad week
The patch is actually right, but bust_spinlocks still blindly stops on locks that may not need to be stomped on.
-ben -- "You will be reincarnated as a toad; and you will be much happier." - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |