Messages in this thread | | | Date | Fri, 02 Aug 2002 15:49:06 -0400 | From | Brian Gerst <> | Subject | Re: [PATCH] Toshiba Laptop Support and IRQ Locks |
| |
Jonathan Buzzard wrote: > alan@lxorguk.ukuu.org.uk said: > >>Hi, >> >>Toshiba laptop support is broken. Here's my rookie attempt at fixing >>it. > > > Whats broken? I have not seen the patch, though I don't track the latest > 2.5 kernels either. > > >>Looks basically sound. You probably want to use spinlock_irqsave - the >>spin locks are less overhead than the reader/writer locks and you >>don't really seem to be using it for anything else. I'm assuming we >>want the irqsave to block interrupts because the I/O cycles might have >>to happen one after another - if not they could be relaxed - perhaps >>Jonathan knows ? > > > Someone show me the patch and I can say for sure. > > Two things to bare in mind, Toshiba have yet to do any sort of > multi processor laptop, are extremely unlikely to ever manufacture > one, and to the best of my knowledge the module only loads on Toshiba > laptops. If it loads on anything else it is broken and needs fixing > so it does not.
What about P4 Hyperthreading?
-- Brian Gerst
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |