Messages in this thread |  | | Date | Mon, 19 Aug 2002 17:25:01 -0300 (BRT) | From | Rik van Riel <> | Subject | Re: [PATCH] rmap bugfix, try_to_unmap |
| |
On Mon, 19 Aug 2002, Daniel Phillips wrote: > On Monday 19 August 2002 22:15, Rik van Riel wrote: > > On Mon, 19 Aug 2002, Daniel Phillips wrote: > > > On Monday 12 August 2002 16:58, Rik van Riel wrote: > > > > case SWAP_FAIL: > > > > ret = SWAP_FAIL; > > > > - break; > > > > + goto give_up; > > > > > > Yes, I looked at that many times while reading the break as a 'break > > > from loop' every time. Using the same keyword to mean 'stop looping' > > > and 'endcase' was, by any measure, a stupid idea. > > > > What's even more curious is that 'continue' has the exact > > same effect on 'switch' ... > > Come to think of it, what you want there is: > > case SWAP_FAIL: > return SWAP_FAIL;
We still want to try to convert the thing to a direct pointer, in case only the last task was using mlock().
regards,
Rik -- Bravely reimplemented by the knights who say "NIH".
http://www.surriel.com/ http://distro.conectiva.com/
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |