Messages in this thread |  | | Date | Sun, 18 Aug 2002 07:28:16 -0700 | From | "H. J. Lu" <> | Subject | Re: PATCH: New fix for CardBus bridge behind a PCI bridge |
| |
On Sun, Aug 18, 2002 at 02:49:48PM +0400, Ivan Kokshaysky wrote: > On Sat, Aug 17, 2002 at 08:36:01AM -0700, H. J. Lu wrote: > > It could be. But I doubt it. At least, I don't think you can treat a > > AGP bridge like a 82801BAM/CAM bridge. I think 82801BAM/CAM is a > > special case. You really have to read the datasheet to know for sure. > > You're right by all means. AGP bridges are _always_ positive decoders. > The problems you've seen were caused by the wrong semicolon somehow > sneaked into the patch: > > +static void __init pci_fixup_transparent_bridge(struct pci_dev *dev) > +{ > + if ((dev->class >> 8) == PCI_CLASS_BRIDGE_PCI && > + (dev->device & 0xff00) == 0x2400); > ^ Ugh.. > + dev->class |= 1; > +} > > Which means that I'm setting bit 0 in the ProgIf for _all_ Intel devices... > I'm really sorry about that.
Yes. It works now. Thanks.
H.J. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |