lkml.org 
[lkml]   [2002]   [Aug]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: VM Regress 0.5 - Compile error with CONFIG_HIGHMEM
On Sat, Aug 17, 2002 at 12:09:20PM +0100, Mel wrote:
> On Thu, 15 Aug 2002, Mel wrote:
>
> >
> > Project page: http://www.csn.ul.ie/~mel/projects/vmregress/
> > Download: http://www.csn.ul.ie/~mel/projects/vmregress/vmregress-0.5.tar.gz
>
> 0.5 won't compile with CONFIG_HIGHMEM set. Apply the following trivial
> patch and it will compile at least. VM Regress has not been tested with
> CONFIG_HIGHMEM set at all but there is no reason for it to fail because no
> presumptions has been made about the number of nodes or zones in the
> machine
>
>
> --- vmregress-0.5/src/sense/kvirtual.c Tue Aug 13 22:43:48 2002
> +++ vmregress-0.5-highmem/src/sense/kvirtual.c Sat Aug 17 12:03:02 2002
> @@ -29,6 +29,11 @@
> #include <linux/mm.h>
> #include <linux/sched.h>
>
> +#ifdef CONFIG_HIGHMEM
> +#include <linux/highmem.h>
> +#include <asm/highmem.h>
> +#endif

Shouldn't an undonditional #include <linux/highmem.h> do it much cleaner?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:28    [W:0.079 / U:4.520 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site