lkml.org 
[lkml]   [2002]   [Aug]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [patch] config language dep_* enhancements
    From

    [Roman Zippel]
    > with the latest modifications this can be written as:
    >
    > dep_tristate NEW !OLD
    > dep_tristate OLD !NEW
    >
    > This still has the back reference and you have to run 'make config'
    > twice to change NEW from n to y.

    I don't see this as a big problem. Most people don't use the bare
    Configure script anyway, except for 'make oldconfig'.

    With the ! patch, Menuconfig does the right thing here.

    > It's possible to fix this:
    >
    > tristate DRV
    > if [ DRV == y ]; then
    > choice OLD NEW
    > fi
    > if [ DRV == m ]; then
    > dep_tristate NEW DRV
    > dep_tristate OLD DRV
    > fi

    Simpler and perhaps more intuitive:

    tristate DRV
    dep_mbool DRV_OLD DRV

    dep_mbool COMMON_OPT DRV
    dep_mbool OLD_OPT1 DRV_OLD
    dep_mbool OLD_OPT2 DRV_OLD
    dep_mbool NEW_OPT1 DRV !DRV_OLD
    dep_mbool NEW_OPT2 DRV !DRV_OLD

    I don't see a real need for a separate symbol announcing DRV_NEW. Let
    the Makefile cope.

    Peter
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:28    [from the cache]
    ©2003-2014 Jasper Spaans. hosted at Digital Ocean