Messages in this thread | | | Date | Sun, 11 Aug 2002 12:49:56 -0600 | From | Erik Andersen <> | Subject | Re: Linux 2.4.20-pre1 |
| |
On Sun Aug 11, 2002 at 08:46:19PM +0100, Alan Cox wrote: > On Sun, 2002-08-11 at 09:57, Erik Andersen wrote: > > On Mon Aug 05, 2002 at 07:40:56PM -0300, Marcelo Tosatti wrote: > > > > > > So here goes -pre1, with a big -ac and x86-64 merges, plus other smaller > > > stuff. > > [------------snip------------] > > > <alan@irongate.swansea.linux.org.uk> (02/08/05 1.629) > > > [PATCH] PATCH: Add EFI partition support > > > > Needs this to compile.... > > > > --- linux/include/asm-ia64/efi.h.orig Sun Aug 11 01:41:10 2002 > > +++ linux/include/asm-ia64/efi.h Sun Aug 11 01:43:38 2002 > > @@ -166,6 +166,9 @@ > > * EFI Configuration Table and GUID definitions > > */ > > > > +#define NULL_GUID \ > > + ((efi_guid_t) { 0x00000000, 0x0000, 0x0000, { 0x00, 0x00, 0x0, 0x00, 0x00, 0x00, 0x00, 0x00 }}) > > + > > Not a good plan. EFI can be used on non ia64 so NULL_GUID belongs > somewhere else
I know. But if you look at the source, the generic stuff is directly including asm-ia64/efi.h, so this makes it compile. I agree having the generic stuff include asm-ia64 code is really stupid, but changing that seemed far more invasive and frankly, I don't even know what an "EFI" is, so I didn't want to mess with it beyond making it compile per how it is currently doing things,
-Erik
-- Erik B. Andersen http://codepoet-consulting.com/ --This message was written using 73% post-consumer electrons-- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |