lkml.org 
[lkml]   [2002]   [Jul]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: dead keyboard in lk 2.5.25
On Sun, Jul 07, 2002 at 04:45:54PM +0100, Russell King wrote:
> On Sun, Jul 07, 2002 at 10:20:16AM -0400, Douglas Gilbert wrote:
> > --- linux/drivers/input/serio/i8042.c Sat Jul 6 08:57:35 2002
> > +++ linux/drivers/input/serio/i8042.c2525fix Sun Jul 7 09:52:50 2002
> > @@ -269,8 +269,11 @@
> > */
> >
> > if (request_irq(values->irq, i8042_interrupt, 0, "i8042", NULL)) {
> > - printk(KERN_ERR "i8042.c: Can't get irq %d for %s\n", values->irq, values->name);
> > - return -1;
> > + free_irq(values->irq, NULL);
> > + if (request_irq(values->irq, i8042_interrupt, 0, "i8042", NULL)) {
> > + printk(KERN_ERR "i8042.c: Can't get irq %d for %s\n", values->irq, values->name);
> > + return -1;
> > + }
> > }
> >
> > /*
>
> Hmm, interesting concept. "If someone else is using my resource, I'll
> free it for them, and re-claim it". It sounds very much like a hack
> rather than a fix to me.
>
> I'd guess the real solution would be to stop pc_keyb being initialised
> when you're trying to use i8042.c. Vojtech?

The real solution is to delete pc_keyb.c. But that'll take some time
yet. i8042.c is there so that the build problems, and other obvious
stuff gets fixed. Later we can start actually using it.

--
Vojtech Pavlik
SuSE Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:22    [W:0.051 / U:22.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site