Messages in this thread Patch in this message |  | | Date | Thu, 25 Jul 2002 01:16:20 -0600 (MDT) | | From | Thunder from the hill <> | | Subject | Re: cli-sti-removal.txt fixup |
| |
Hi,
On Wed, 24 Jul 2002, Greg KH wrote: > > Ah, sorry, I didn't get that from cli-sti-removal.txt. Actually it > > looks like cli-sti-removal.txt is a bit wrong, as there is no > > local_irq_save_off() function. I'll send a patch for that next.
In my understanding things look rather like this:
--- linus-2.5/Documentation/cli-sti-removal.txt 2002-07-24 23:10:23.000000000 -0600 +++ thunder-2.5/Documentation/cli-sti-removal.txt 2002-07-25 01:12:45.000000000 -0600 @@ -96,8 +96,8 @@ drivers that want to disable local interrupts (interrupts on the current CPU), can use the following five macros: - local_irq_disable(), local_irq_enable(), local_irq_save(flags), - local_irq_save_off(flags), local_irq_restore(flags) + local_irq_disable(), local_irq_enable(), local_save_flags(flags), + local_irq_save(flags), local_irq_restore(flags) but beware, their meaning and semantics are much simpler, far from that of the old cli(), sti(), save_flags(flags) and restore_flags(flags) @@ -107,11 +107,11 @@ local_irq_enable() => turn local IRQs on - local_irq_save(flags) => save the current IRQ state into flags. The + local_save_flags(flags) => save the current IRQ state into flags. The state can be on or off. (on some architectures there's even more bits in it.) - local_irq_save_off(flags) => save the current IRQ state into flags and + local_irq_save(flags) => save the current IRQ state into flags and disable interrupts. local_irq_restore(flags) => restore the IRQ state from flags. Regards, Thunder -- (Use http://www.ebb.org/ungeek if you can't decode) ------BEGIN GEEK CODE BLOCK------ Version: 3.12 GCS/E/G/S/AT d- s++:-- a? C++$ ULAVHI++++$ P++$ L++++(+++++)$ E W-$ N--- o? K? w-- O- M V$ PS+ PE- Y- PGP+ t+ 5+ X+ R- !tv b++ DI? !D G e++++ h* r--- y- ------END GEEK CODE BLOCK------ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |