Messages in this thread | | | Date | Mon, 22 Jul 2002 15:49:39 +0200 (CEST) | From | Ingo Molnar <> | Subject | Re: [patch] cli()/sti() cleanup, 2.5.27-A2 |
| |
On Mon, 22 Jul 2002, Christoph Hellwig wrote:
> yupp, you're right. could you take the prototype changes anyway?
i'm hesitant for a number of reasons. Eg. irq_save_off(flags) has to be a macro, otherwise we move the assignment into the irqs-off section. Compare:
flags = irq_save_off();
with: irq_flags_off(flags);
sure, it could be written as:
flags = irq_save(); irq_off();
but then again the macro form is more compact.
Ingo
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |