Messages in this thread | | | Date | Mon, 22 Jul 2002 13:21:44 +0200 | From | Marcin Dalecki <> | Subject | Re: [PATCH] 2.5.27 sysctl |
| |
Alan Cox wrote: > On Mon, 2002-07-22 at 11:56, Marcin Dalecki wrote: > >>Christoph Hellwig wrote: >> >>>On Mon, Jul 22, 2002 at 12:42:07PM +0200, Marcin Dalecki wrote: >>> >>> >>>>This is making the sysctl code acutally be written in C. >>>>It wasn't mostly due to georgeous ommitted size array "forward >>>>declarations". As a side effect it makes the table structure easier to >>>>deduce. >>> >>> >>>Please don't remove the trailing commas in the enums. they make adding >>>to them much easier and are allowed by gcc (and maybe C99, I'm not >>>sure). >> >>It's an GNU-ism. If you have any problem with "adding vales", just >>invent some dummy end-value. I have a problem with using -pedantic. > > > You seem to have it permanently engaged 8) > > If you are upset about that GNUism why doesn't your patch fix the other > GNU-isms in the same file ? Also the entire kernel is *full* of GNU C > extensions.
That's a common rumour. struct inits are going to go anyway. The rest is only about 30 ({ ... }) in inclue/linux. Of course some of the GNU extensions are actually usefull. Trailing , at enum declarations make up for a nice shift reduce conflict expirence in yacc. (And perhaps slower compilation...)
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |