lkml.org 
[lkml]   [2002]   [Jul]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [patch] "big IRQ lock" removal, 2.5.27-A9
    From
    Date
    On Sun, 2002-07-21 at 17:40, Russell King wrote:
    > On Mon, Jul 22, 2002 at 02:31:16AM +0200, Ingo Molnar wrote:
    > > +drivers that want to disable local interrupts (interrupts on the
    > > +current CPU), can use the following four macros:
    > > +
    > > + __cli(), __sti(), __save_flags(flags), __restore_flags(flags)
    >
    > Last mail before zzz (hopefully) - what about
    > local_irq_{enable,disable,save,restore} ?
    >
    > With the exception of local_irq_save() which is actually
    > local_irq_save_disable(), I find these to be more "descriptive" of
    > their function.

    Yes and double yes.

    And for two reasons: First, the __ prefix is unnecessary now. Second,
    not all the world is an x86 (it just looks that way).

    local_irq_foo is definitely preferred.

    I'd make the patch and go through the effort to rename and replace if
    Linus assured me it was in.

    Robert Love

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:22    [W:0.022 / U:34.076 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site