lkml.org 
[lkml]   [2002]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC] Rearranging struct dentry for cache affinity


On Tue, 16 Jul 2002, Rusty Russell wrote:

> On Sat, 13 Jul 2002 05:11:46 -0400 (EDT)
> Alexander Viro <viro@math.psu.edu> wrote:
>
> > futex.c is seriously b0rken.
>
> Really? Other than changing over to get_sb_psuedo(), what does your patch
> fix? As the filesystem should never be unmounted, what am I missing?
> > filp->f_op = &futex_fops;
> > - filp->f_dentry = dget(futex_dentry);
> > + filp->f_vfsmnt = mntget(futex_mnt);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> > + filp->f_dentry = dget(futex_mnt->mnt_root);

Uninitialized ->f_vfsmnt == quite a few places in the tree very unhappy.
E.g. any access to /proc/<pid>/fd/<n>.

I'd say that "any user can oops the kernel in a couple of lines" does
qualify for serious breakage...

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:22    [W:0.086 / U:1.896 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site