Messages in this thread | | | Date | Fri, 12 Jul 2002 22:58:28 +0200 | From | Dave Jones <> | Subject | Re: [RFC] Rearranging struct dentry for cache affinity |
| |
On Fri, Jul 12, 2002 at 01:38:35PM -0700, Paul Menage wrote:
> - dentry->d_vfs_flags |= DCACHE_REFERENCED; > +#ifdef CONFIG_SMP > + if(!(dentry->d_vfs_flags & DCACHE_REFERENCED)) > +#endif > + dentry->d_vfs_flags |= DCACHE_REFERENCED;
Yuck. Is doing this conditional on UP really a measurable effect? Somehow I doubt it's worth this ugliness. If you must microoptimise to this level, at least try and keep the code clean.
Dave
-- | Dave Jones. http://www.codemonkey.org.uk | SuSE Labs - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |