Messages in this thread |  | | Date | Fri, 07 Jun 2002 14:24:03 -0400 | From | Jeff Garzik <> | Subject | Re: [PATCH][2.5] tulip: change device names |
| |
Thunder from the hill wrote:
>Hi, > >On Fri, 7 Jun 2002, Jeff Garzik wrote: > > >>Thanks for the effort, that was a quick turnaround :) >> >>But unfortunately the patch is wrong. >> >>You need to use an index which counts _tulip_ boards, which implies that >>the index is local to the driver. Currently the only such counter is >>board_idx, which is a variable local to tulip_init_one(). >> >> > >Would you suggest > >a) setting it in some global struct (tulip_private etc.)? > >
Yes, I would add "board_idx" member to struct tulip_private, and initialize it early in tulip_init_one()
Take care to update the printk's of only those functions which are actually called from tulip_init_one() before register_netdev(). All other references are correctly using dev->name. "tulip%d" is only needed at startup.
Jeff
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |