Messages in this thread | | | Date | Wed, 5 Jun 2002 20:23:12 -0500 (CDT) | From | Kai Germaschewski <> | Subject | Re: [patch] PCI device matching fix |
| |
On Wed, 5 Jun 2002, Patrick Mochel wrote:
> Alright, I can deal. I expanded on what you had, and moved it into the > core. It's not tested, but lemme know what you think.
Looks fine to me, though I didn't test it either ;-)
However, it's possible to put the struct completion onto the stack as I suggested, it saves a couple of bytes in struct driver, and, more importantly, it'll blow up if the refcount goes to zero before driver_unregister() has been called, so it provides a bug trap for messed-up refcounting.
Anyway, that's a question of taste, I suppose.
--Kai
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |