[lkml]   [2002]   [Jun]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [patch] i386 "General Options" - begone [take 2]
In message <> you write:
> While moving software suspend, I also took the chance to tweak the
> entry.

For trivial at least, please split the patches. It makes it easy for
me and/or Linus to accept only one.

Also, please mention clearly if you obsolete a previous trivial patch...

> diff -Naur -X dontdiff linux-2.5.20-clean/arch/i386/ linux-2.5.20-
> --- linux-2.5.20-clean/arch/i386/ Thu May 30 04:42:46 2002
> +++ linux-2.5.20-config-munging/arch/i386/ Mon Jun 3 12:39:48 200
> @@ -641,7 +641,8 @@
> off or put into a power conserving "sleep" mode if they are not
> being used. There are two competing standards for doing this: APM
> and ACPI. If you want to use either one, say Y here and then also
> - to the requisite support below.
> + to the requisite support below. This option is also required for
> + "software suspend", see below.
> Power Management is most important for battery powered laptop
> computers; if you have a laptop, check out the Linux Laptop home

Like code, descriptions develop scar tissue when you do the "minimally
invasive" change. Consider this classic trap-for-skimmers from the
glibc "snprintf" man page, and learn:

Return value
These functions return the number of characters printed
(not including the trailing `\0' used to end output to
strings). snprintf and vsnprintf do not write more than
size bytes (including the trailing '\0'), and return -1 if
the output was truncated due to this limit. (Thus until
glibc 2.0.6. Since glibc 2.1 these functions follow the
C99 standard and return the number of characters (exclud­
ing the trailing '\0') which would have been written to
the final string if enough space had been available.)

Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2005-03-22 13:26    [from the cache]
©2003-2014 Jasper Spaans. hosted at Digital Ocean