Messages in this thread | | | Date | Mon, 3 Jun 2002 12:19:43 +0000 | From | Pavel Machek <> | Subject | Re: do_mmap |
| |
Hi!
> what about the do_mmap/do_mmap_pgoff implementation? > reurn-type: _unsigned_ long (which should be ok cause we've to return > an adress if len == 0) > on error: -ERR_* > > and the checks in various places are really strange. - well some > places check for: > o != NULL > o > -1024UL > o ... > > guess this nedds some cleanup.
While you are at it... fs/binfmt_elf does mmaps but does not check for errors. And errors actually do happen there :-(
-- Philips Velo 1: 1"x4"x8", 300gram, 60, 12MB, 40bogomips, linux, mutt, details at http://atrey.karlin.mff.cuni.cz/~pavel/velo/index.html.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |