lkml.org 
[lkml]   [2002]   [Jun]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] 2.5.24 : drivers/net/defxx.c
Zwane,
I agree, although eventually I envision the code to look like...

if(pci_set_dma_mask(pdev, 0xffffffff))
{
printk(KERN_WARNING "defxx : No suitable DMA available\n");
// Add appropriate action, such as
// goto err_dma_exit;
// OR
return -ENOMEM;
}

Thats why I have the braces (multiple statements).

Regards,
Frank

> Zwane Mwaikambo wrote:
>
>> On Sun, 23 Jun 2002, Frank Davis wrote:
>>
>>
>>> -
>>> + if(pci_set_dma_mask(pdev, 0xffffffff))
>>> + {
>>> + printk(KERN_WARNING "defxx : No suitable DMA available\n");
>>> + }
>>
>>
>>
>> Minor nit,
>> CodingStyle prefers this style;
>>
>> if (pci_set_dma_mask(pdev, 0xffffffff))
>> printk(KERN_WARNING "defxx : No suitable DMA available\n");
>>
>> Thanks,
>> Zwane Mwaikambo
>>
>
>


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:27    [W:1.472 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site