lkml.org 
[lkml]   [2002]   [Jun]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] 2.5.24 : drivers/scsi/inia100.c
Greetings,

Frank Davis <fdavis@si.rr.com> :
> Hello all,
> This patch adds the DMA mapping check (1st step for
> Documentation/DMA-mapping.txt compliance). Please review.

- please take a look at Documentation/CodingStyle
- if pci_set_dma_mask() fails, the driver shouldn't go on as if nothing
happened. See what other drivers do (net/acenic.c for example)
- the interesting part of DMA mapping conversion is more a matter of
memory descriptor handling (and phys_to_virt/friends removal)

--
Ueimor
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:27    [W:0.038 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site