Messages in this thread | | | Date | Fri, 21 Jun 2002 12:05:01 +0200 | From | Martin Dalecki <> | Subject | Re: hda: error: DMA in progress.. |
| |
Użytkownik Jens Axboe napisał: > Martin, > > I gave 2.5.24 a spin, and it quickly dies with the error in subject, > under moderate disk load. It's an IBM travel star on a PIIX4. >
if (test_bit(IDE_DMA, ch->active)) { printk(KERN_ERR "%s: error: DMA in progress...\n", drive->name); break; }
Well I did the change we where talking about .waiting_for_dma -> xxx_bit(IDE_DMA. And I was asking about it's possible interactions with TCQ. And now we see that it is indeed apparently really interacting with the TCQ code in bad ways. But if I look down from the above code (Just below in ide.c)
if (blk_queue_plugged(&drive->queue)) { BUG_ON(!drive->using_tcq); break; }
It seems like the check which is catching reality right now is bogous in itself. Becouse having DMA running would be only problematic if the queue was still plugged. (Right?) So please just disable the check.
This time it's no new damage - just detecting weak code from the past...
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |