Messages in this thread | | | Date | Wed, 12 Jun 2002 19:13:26 -0700 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH] 2.5.21 Nonlinear CPU support |
| |
Anton Altaparmakov wrote: > > allocate_compression_buffers() currently allocates all buffers up > smp_num_cpus which is fine without hotswap cpus. Once hotswap cpus path > goes in, then the allocation will be (pseudo code): > > for (i = 0; i < NR_CPUS; i++) { > if (cpu_possible(i)) { > ntfs_compression_buffer[i] = vmalloc(); > // TODO handle errors > } > } > > That means in words that we allocate buffers only once and for all > existing cpu SOCKETS, i.e. including all potentially hotpluggable cpus > which are currently offline. - If someone invents hotpluggable cpu sockets > at some point then they should be burnt at the stake! (-; >
Note that with my code, you don't allocate any memory until you have actually seen a particular CPU being *used.* All very simple...
-hpa
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |