lkml.org 
[lkml]   [2002]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [CHECKER] 54 missing null pointer checks in 2.4.17
Date
> Thanks for these. Patch for 2.4.19-pre10 to fix catc and se401 bugs currently 
> compile testing :)

Good deal! Thanks for letting us know.

> > se401->width=kmalloc(se401->sizes*sizeof(int), GFP_KERNEL);
> > se401->height=kmalloc(se401->sizes*sizeof(int), GFP_KERNEL);
> > for (i=0; i<se401->sizes; i++) {
> > se401->width[i]=cp[6+i*4+0]+cp[6+i*4+1]*256;
> > se401->height[i]=cp[6+i*4+2]+cp[6+i*4+3]*256;
> > }
> > sprintf (temp, "%s Sizes:", temp);
> > for (i=0; i<se401->sizes; i++) {
> > Error --->
> > sprintf(temp, "%s %dx%d", temp, se401->width[i], se401->height[i]);
> > }
> > info("%s", temp);
> > se401->maxframesize=se401->width[se401->sizes-1]*se401->height[se401->size
> >s-1]*3; ---------------------------------------------------------
> bradh: this one is wrong. If it didn't oops on the previous one, it won't oops
> here :)

Yeah, indeed. The current rewrite doesn't (yet) have false path suppression
back in and I'm getting too old to be reliable. Thanks for pointing it
out.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:26    [W:0.163 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site