Messages in this thread Patch in this message | | | Date | Thu, 9 May 2002 19:42:42 -0700 | From | Greg KH <> | Subject | Re: 2.5.15 laziness in export-objs |
| |
On Fri, May 10, 2002 at 12:42:51PM +1000, Keith Owens wrote: > 2.5.15 has four Makefiles where all objects are marked as exporting > symbols. This is lazy coding and causes spurious rebuilds. Please > specify only those objects that really export symbols. > > Also the export list is independent of whether an object is selected or > not. That is, export-objs is unconditional.
Does this patch fix up arch/i386/pci/Makefile and drivers/pci/Makefile properly?
thanks,
greg k-h
diff -Nru a/arch/i386/pci/Makefile b/arch/i386/pci/Makefile --- a/arch/i386/pci/Makefile Thu May 9 20:50:36 2002 +++ b/arch/i386/pci/Makefile Thu May 9 20:50:36 2002 @@ -24,6 +24,4 @@ obj-y += irq.o common.o endif # CONFIG_VISWS -export-objs += $(obj-y) - include $(TOPDIR)/Rules.make diff -Nru a/drivers/pci/Makefile b/drivers/pci/Makefile --- a/drivers/pci/Makefile Thu May 9 20:50:36 2002 +++ b/drivers/pci/Makefile Thu May 9 20:50:36 2002 @@ -37,7 +37,8 @@ obj-y += syscall.o endif -export-objs := $(obj-y) +export-objs := access.o hotplug.o pci.o pci-driver.o \ + pool.o probe.o proc.o search.o include $(TOPDIR)/Rules.make - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |