lkml.org 
[lkml]   [2002]   [May]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] double flush_page_to_ram
On Thu, 9 May 2002, David S. Miller wrote:
> From: Hugh Dickins <hugh@veritas.com>
> Date: Thu, 9 May 2002 13:03:52 +0100 (BST)
>
> filemap_nopage and shmem_nopage do flush_page_to_ram before returning
> page, but do_no_page also does flush_page_to_ram on any page it slots
> into the user address space. It's memory.c's business, remove it from
> shmem and filemap (and cut outdated comment from when filemap copied).
>
> Wrong, consider the case where we do early COW in do_no_page, you miss
> a flush on the new-new page.

Of course we do, and then we don't map it into user address space;
if it ever gets mapped into user address space later, do_no_page
does the flush_page_to_ram then.

Hugh

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:22    [W:0.108 / U:1.884 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site