lkml.org 
[lkml]   [2002]   [May]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Possible SCSI (sr) mini-cleanup
On Tue, May 07, 2002 at 04:02:35PM -0600, Andreas Dilger wrote:
> On May 07, 2002 14:50 -0600, Thunder from the hill wrote:
> > I don't see where the variable and the label have been used. Are they
> > useful for anything? If they are, tell me please!
>
> > @@ -723,8 +721,6 @@
> > goto cleanup_cds;
> > memset(sr_sizes, 0, sr_template.dev_max * sizeof(int));
> > return 0;
> > -cleanup_sizes:
> > - kfree(sr_sizes);
> > cleanup_cds:
> > kfree(scsi_CDs);
> > cleanup_devfs:
>
> Note that you are also removing the "kfree(sr_sizes)" which is
> definitely used...

There's a return 0 on the line before the kfree(sr_sizes);,
so either there is a goto cleanup_sizes somewhere, or the code is dead.

Regards: David Weinehall
_ _
// David Weinehall <tao@acc.umu.se> /> Northern lights wander \\
// Maintainer of the v2.0 kernel // Dance across the winter sky //
\> http://www.acc.umu.se/~tao/ </ Full colour fire </
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:25    [W:0.028 / U:22.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site