lkml.org 
[lkml]   [2002]   [May]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] 2.5.14 IDE CD-ROM PIO mode

while we are here, I think that drivers shouldn't take
requests < hardsect_size, it should be handled by block layer

requests On Tue, 7 May 2002, Martin Dalecki wrote:

> Uz.ytkownik Christoph Hellwig napisa?:
> > On Tue, May 07, 2002 at 11:57:20AM +0200, Martin Dalecki wrote:
> >
> >>>@@ -962,7 +962,7 @@
> >>>
> >>> /* First, figure out if we need to bit-bucket
> >>> any of the leading sectors. */
> >>>- nskip = MIN(rq->current_nr_sectors - bio_sectors(rq->bio), sectors_to_transfer);
> >>>+ nskip = MIN((int)(rq->current_nr_sectors - bio_sectors(rq->bio)), sectors_to_transfer);
> >>
> >
> > What about a s/MIN/min/g in the idea driver to easily catch such bugs?
>
> Good idea partially already implemented :-).
> At least the generic code and the host chip driver code are alread
> switched to using those "chatch them" macros.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:25    [W:0.048 / U:4.912 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site