Messages in this thread |  | | Date | Sun, 05 May 2002 23:51:53 +0100 | From | Anton Altaparmakov <> | Subject | Re: [patch 1/10] suppress allocation warnings for radix-tree allocations |
| |
At 23:06 05/05/02, Andrew Morton wrote: >Daniel Phillips wrote: > > > > On Sunday 05 May 2002 22:53, Andrew Morton wrote: > > > The recently-added page allocation failure warning generates a lot of > > > noise due to radix-tree node allocation failures. Those messages are > > > not interesting. > > > > > > But I think the warning is otherwise useful - "I got an allocation > > > failure and then it crashed" is better than "it crashed". > > > > > > The patch suppresses the message for ratnode allocation failures. > > > > > > ===================================== > > > > > > --- 2.5.13/mm/vmscan.c~radix-tree-warning Sun May 5 13:31:59 2002 > > > +++ 2.5.13-akpm/mm/vmscan.c Sun May 5 13:31:59 2002 > > > @@ -58,6 +58,7 @@ swap_out_add_to_swap_cache(struct page * > > > int ret; > > > > > > current->flags &= ~PF_MEMALLOC; > > > + current->flags |= PF_RADIX_TREE; > > > > Isn't that really 'PF_NO_WARN_ALLOC'? > > > >Yup, that would make more sense. > >Or __GFP_I_DONT_REALLY_CARE ;)
Surely this is only a temporary flag which together with the warning message will disappear later on so debating about its name is, err, silly? (((-;
Anton
-- "I've not lost my mind. It's backed up on tape somewhere." - Unknown -- Anton Altaparmakov <aia21 at cantab.net> (replace at with @) Linux NTFS Maintainer / IRC: #ntfs on irc.openprojects.net WWW: http://linux-ntfs.sf.net/ & http://www-stu.christs.cam.ac.uk/~aia21/
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |