lkml.org 
[lkml]   [2002]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: 2.4.19pre8aa2
Christoph Hellwig wrote:
>
> On Sat, May 04, 2002 at 04:54:40PM +0200, Andrea Arcangeli wrote:
> > Only in 2.4.19pre8aa2: 00_comx-driver-compile-1
> >
> > Export proc_get_inode for kernel/drivers/net/wan/comx.o so
> > it can link as a module, noticed by Eyal Lebedinsky.
>
> Don't do this - proc_get_inode is static for a reason and doing this
> export in the SuSE tree for ages doesn't make it any better.
>
> The driver needs serious fixing instead.

I agree with this. However, since this driver cannot be built, and
since the latest modutils will exit badly for unresolved, I strongly
believe that the comx driver should not be offered (disable it in
the Config.in) until it is fixed - 2.4 being a stable kernel.

I had to wrap 'depmod' with a script to ignore failures in order
to get through a full build (which includes the kernel plus a few
extra modules like NVdriver, dc395, lm_sensors).

We have already been through this argument before, it is now up to
Marcelo to decide on the policy here.


--
Eyal Lebedinsky (eyal@eyal.emu.id.au) <http://samba.org/eyal/>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:22    [W:0.071 / U:0.288 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site