Messages in this thread | | | Date | Wed, 29 May 2002 15:03:27 +0200 | From | Martin Dalecki <> | Subject | Re: [PATCH] 2.5.18 IDE 73 |
| |
Gerald Champagne wrote: >>- ide_driveid_update is gone. We don't report the drive id through >>/proc/ide and we don't have to update it any longer on the fly. Still >>someone out there complaining that it went away!? > > > But the id information is still available through the ioctl interface. > ide_driveid_update was used to update the dma_ultra, dma_mword, and > dma_lword fields in the id structure after changing the rate with an > ioctl command. Won't these fields be wrong if the rate is changed after > initialization? Won't "hdparm -i" show outdated and incorrect > information. > > It's good to see the duplicate identify routine go away, but the ioctl > shouldn't return incorrect information. Can the remaining identify > routine be modified and called directly from the ioctl that returns the > id information? > > Gerald
Dear Gerald please look closer. The hdparm -i is executing the drive id command directly and does *not* rely on the internally permanently dragged around id structure. So the change I did is entierly fine. Just go ahead and check whatever hdparm -i /dev/hdx reports the proper thing after changing some dma setting. It does - I did check it :-).
BTW> The next thing to be gone is simple the fact that we drag around the id information permanently, where infact only some capabilitie fields are sucked out of it and the device identification string is only needed for reporting during boot-up.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |